Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port
......................................................................
Patch Set 7: (3 inline comments)
argh, how could it be that my comments have not been posted?
I see that the whole world and his uncle are waiting for this. Maybe we can do
a simple ovirt-3.1-only patch? Because I am not yet happy with what is
happening in this patch. sorry...
....................................................
File vdsm/utils.py
Line 56: def isHostReachable(host, port=None, ssl=True,
timeout=socket._GLOBAL_DEFAULT_TIMEOUT):
Is there any reason to put this function outside vdsm_reg's engine.py?
it is about http reachability, not general host reachability. but in the
context of engine.py this name can fly.
Line 59: Connect = httplib.HTTPSConnection
"Connection" would be a better name.
these assignment should sit outside of the try block - they never raise
socket.error.
Line 72: if portNumber == "443":
this function would look simpler if it was a dictionary lookup:
{'443': ('8443', True) ..
but I need a doctrting to understand what "compatible" means.
--
To view, visit http://gerrit.ovirt.org/5367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d1ca0614741d24b512572f101f848b24e6d3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
