Ayal Baron has posted comments on this change. Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf ......................................................................
Patch Set 4: I would prefer that you didn't submit this (3 inline comments) .................................................... File vdsm/storage/storageServer.py Line 255: "4.0 of RHEV. Please upgrade domains to V2 or greater and " s/V2/V3/ Line 265: self.__dict__[optMap[parts[0]]] = parts[1] instead of messing around with the properties: add this at start of method: opts = {'retrans': None, 'version': None, 'timeout': None} then: if parts[0] in opts: opts[parts[0]] = parts[1] then move assignment to self._timeout and friends to end of method self._timeout = opts['timeout']... Line 269: timeout = 600; this would change to opts['timeout'] etc -- To view, visit http://gerrit.ovirt.org/5368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches