Ayal Baron has posted comments on this change. Change subject: BZ#840407 - Create a fake template when moving to backup SD. ......................................................................
Patch Set 1: (2 inline comments) .................................................... Commit Message Line 12: All the related fake template code should be removed. this sentence is redundant and out of context. .................................................... File vdsm/storage/hsm.py Line 1346: tName = e.absentTemplateUUID you're assuming that only missing template would throw this exception. Although correct for current implementation, the exception is generic and might be reused... -- To view, visit http://gerrit.ovirt.org/6519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches