Dan Kenigsberg has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/constants.py.in
Line 117: EXT_OPENSSL = '@OPENSSL_PATH@'
is this really needed? I hope it can be avoided. we would like to make
constats.py thinner and thinner.
....................................................
File vdsm-tool/base.py
Line 25: def exec_command(argv):
we have vdsm.utils.execCmd. Why do we want this function (and its enclosing
module)?
....................................................
File vdsm-tool/validate_libvirt_certs.py
Line 51: exec_command([EX_UNPERSIST, CACERT_PATH, '1'])
it's not your fault, but this function does much more than just validation.
please explain what it does (and why?) and even better - change the name.
Line 53: shutil.copy('%s/file' % BASE_PATH, CACERT_PATH)
are you sure 'file' should be quoted here?
--
To view, visit http://gerrit.ovirt.org/5961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6504ae2e3c8ffa0c33d7ba22a7c16597a51945
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
