Zhou Zheng Sheng has posted comments on this change.

Change subject: call sync before umount in mkFloppyFs
......................................................................


Patch Set 1:

I have tried lazy umount as well, it does not work. The test case will mount 
the image immediately after the previous umount, if I use lazy umount, the 
check will fail, because the data is not synced to the image yet. So I have to 
sync.

By the way, I tried fsync as well. The result is, if I fsync every file and 
close them, umount still throws exception. I have to fsync the files and umount 
lazyli to get it work. With fsync and a lazy umount, the data is written to the 
disk before umount, so when the test case mount again immediately, it checks 
the contents succesfully.

--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to