Nir Soffer has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/39969/10/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 79: self._outbox.add_last(frame) Line 80: Line 81: def remove_subscriptions(self): Line 82: for sub in self._sub_ids.itervalues(): Line 83: self._remove_subscription(sub) > yes. it can be accessed by other threads. Then itervalues (or iteritems) is not safe. You must either use a lock, or copy the values (use values()). You cannot use iteration on a container if the container can be modified during the iteration. Line 84: Line 85: self._sub_ids.clear() Line 86: Line 87: def _cmd_connect(self, dispatcher, frame): -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
