Dan Kenigsberg has submitted this change and it was merged. Change subject: mailbox: Use threading instead of thread ......................................................................
mailbox: Use threading instead of thread SPM MailMonitor thread was created using the thread.start_new_thread. This creates a thread with the unhelpful name "Dummy-1234". Also the locks used by this thread were created using thread.allocate_lock(). I'm not aware of any advantages of using the lower level thread module, and searching vdsm history back to 2009 does not show any clue why this code was used. Now we use the threading module used for all other threads and locks in vdsm. This allows more helpful thread names in the next patches. Change-Id: I17a486dab5d6355cfd35f1618b96d25ce454dff2 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/41061 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Jenkins CI --- M vdsm/storage/storage_mailbox.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17a486dab5d6355cfd35f1618b96d25ce454dff2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
