Piotr Kliczewski has posted comments on this change.

Change subject: status: adding elapsed time in millis
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40904/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 411:     """
Line 412:     def _get_elapsed_time_in_millis(self):
Line 413:         return str(
Line 414:             int(round(utils.monotonic_time() * 1000)) -
Line 415:             int(round(self._startTime * 1000))
> self._startTime is initialized using time.time():
The idea was to use _startTime. It seems that there are issues with qemu so we 
need to think again how to do it well.
Line 416:         )
Line 417: 
Line 418:     lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 419: 


-- 
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to