Dan Kenigsberg has posted comments on this change. Change subject: Specify the ACPI flag when shutting down VMs ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 2000: def _acpiShutdown(self): agreed. a function named like that should keep using acpi. however, it does not strike me as horrible to use guest agent when it is available. Why is it a problem for anyone? -- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
