Martin Sivák has posted comments on this change. Change subject: Separate MOM to an external process ......................................................................
Patch Set 8: (4 comments) https://gerrit.ovirt.org/#/c/41602/8/init/systemd/vdsmd.service.in File init/systemd/vdsmd.service.in: Line 4: iscsid.service rpcbind.service supervdsmd.service sanlock.service \ Line 5: vdsm-network.service Line 6: After=multipathd.service libvirtd.service iscsid.service rpcbind.service \ Line 7: supervdsmd.service sanlock.service vdsm-network.service Line 8: Conflicts=libvirt-guests.service ksmtuned.service > so please do.. Done Line 9: Wants=mom-vdsm.service Line 10: Line 11: [Service] Line 12: Type=simple Line 5: vdsm-network.service Line 6: After=multipathd.service libvirtd.service iscsid.service rpcbind.service \ Line 7: supervdsmd.service sanlock.service vdsm-network.service Line 8: Conflicts=libvirt-guests.service ksmtuned.service Line 9: Wants=mom-vdsm.service > ok.. so we just don't care if we have mom or not. but if it exists we will It will use new MOM instance transparently. Line 10: Line 11: [Service] Line 12: Type=simple Line 13: LimitCORE=infinity https://gerrit.ovirt.org/#/c/41602/8/vdsm/momIF.py File vdsm/momIF.py: Line 35: class MomNotAvailableError(RuntimeError): Line 36: pass Line 37: Line 38: Line 39: class MomThread(object): > please do.. I think its more appropriate Done Line 40: Line 41: def __init__(self, momconf): Line 42: if not _momAvailable: Line 43: raise MomNotAvailableError() Line 51: if port == "-1": Line 52: self.log.error("MOM's RPC interface is disabled") Line 53: raise MomNotAvailableError() Line 54: Line 55: self._mom = xmlrpclib.ServerProxy("http://localhost:"+port) > +1 Done Line 56: self._policy = {} Line 57: Line 58: def getKsmStats(self): Line 59: """ -- To view, visit https://gerrit.ovirt.org/41602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99b81d21080834b7031824dab0a26f45e7eac7af Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
