Allon Mureinik has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/41931/8//COMMIT_MSG Commit Message: Line 6: Line 7: gluster: Verify volume is Replica 3 Line 8: Line 9: Verify that only Replica 3 volumes are used in gluster storage domains. Line 10: Shouldn't this have "Bug-Url: https://bugzilla.redhat.com/1123052"; ? Line 11: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f https://gerrit.ovirt.org/#/c/41931/8/tests/storageServerTests.py File tests/storageServerTests.py: Line 84: 'name': Line 85: '192.168.122.1:/tmp/music', Line 86: 'hostUuid': Line 87: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 88: }, { Unrelated to this patch. If you want to improve formatting, please do so in a separate patch. Line 89: 'name': Line 90: '192.168.122.2:/tmp/music', Line 91: 'hostUuid': Line 92: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 89: 'name': Line 90: '192.168.122.2:/tmp/music', Line 91: 'hostUuid': Line 92: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 93: }, { Unrelated to this patch. If you want to improve formatting, please do so in a separate patch. Line 94: 'name': Line 95: '192.168.122.3:/tmp/music', Line 96: 'hostUuid': Line 97: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 94: 'name': Line 95: '192.168.122.3:/tmp/music', Line 96: 'hostUuid': Line 97: '04eb591b-2fd3-489e-a22c-5d342a3c713d' Line 98: }], Unrelated to this patch. If you want to improve formatting, please do so in a separate patch. Line 99: 'options': {'auth.allow': '*'}, Line 100: 'replicaCount': '3', Line 101: 'stripeCount': '1', Line 102: 'disperseCount': '0', https://gerrit.ovirt.org/#/c/41931/8/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 289: def validate(self): Line 290: replicaCount = self.volinfo[self._volname]['replicaCount'] Line 291: if not replicaCount == '3': Line 292: raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount) Line 293: Do we also want to validate the other parameters described in http://www.ovirt.org/Gluster_Storage_Domain_Reference ? Line 294: def _get_gluster_mount_options(self): Line 295: if "backup-volfile-servers" in self._options: Line 296: self.log.warn("User specified mount options will be used.") Line 297: return "" -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
