Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 18: (4 comments) https://gerrit.ovirt.org/#/c/41931/18//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-06-15 22:42:32 +0300 Line 6: Line 7: gluster: Verify volume is Replica 3 Line 8: Line 9: Verify that only Replica 3 volumes are used in gluster storage domains. > Please explain why we want to support only replica 3, and why we added the Done Line 10: Line 11: Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Line 12: Bug-Url: https://bugzilla.redhat.com/1123052 https://gerrit.ovirt.org/#/c/41931/18/tests/storageServerTests.py File tests/storageServerTests.py: Line 129: if not supported: Line 130: self.assertRaises(se.UnsupportedGlusterVolumeReplicaCountError, Line 131: gluster.validate) Line 132: else: Line 133: gluster.validate() > Since you have to implement both options, better do: Done https://gerrit.ovirt.org/#/c/41931/18/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 278: # - 21692 /usr/bin/glusterfs ... Line 279: # Line 280: CGROUP = "vdsm-glusterfs" Line 281: DIR = "glusterSD" Line 282: ALLOWED_REPLICA_COUNTS = \ > Don't break line line this, it is very fragile - use: Done Line 283: tuple(config.get("gluster", "allowed_replica_counts").split(",")) Line 284: Line 285: def __init__(self, Line 286: spec, https://gerrit.ovirt.org/#/c/41931/18/vdsm/storage/storage_exception.py File vdsm/storage/storage_exception.py: Line 1197: Line 1198: Line 1199: class UnsupportedGlusterVolumeReplicaCountError(StorageException): Line 1200: code = 4710 Line 1201: message = "Gluster volume replica type is not supported" > replica type -> replica count Done Line 1202: Line 1203: def __init__(self, replicaCount): Line 1204: self.replicaCount = replicaCount Line 1205: -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
