Dan Kenigsberg has posted comments on this change. Change subject: net: use KernelConfig instead of RunningConfig in setupNetworks ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42903/1/vdsm/network/api.py File vdsm/network/api.py: Line 860: Line 861: logger.debug("Applying...") Line 862: in_rollback = options.get('_inRollback', False) Line 863: kernel_config = netconfpersistence.KernelConfig(_netinfo) Line 864: normalized_config = kernel_config.normalize( I did not think about normalization myself (and the commit message does not mention why it is needed). Could you add a word about it? Line 865: netconfpersistence.BaseConfig(networks, bondings)) Line 866: with ConfiguratorClass(in_rollback) as configurator: Line 867: # Remove edited networks and networks with 'remove' attribute Line 868: for network, attrs in networks.items(): -- To view, visit https://gerrit.ovirt.org/42903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41232de5b079e6192b3c0f031d0cb24036583c43 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
