Yeela Kaplan has posted comments on this change.

Change subject: Introducing vdsm preset systemd file
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/43032/1/init/systemd/85-vdsmd.preset
File init/systemd/85-vdsmd.preset:

Line 4: enable vdsmd.service
Line 5: enable supervdsmd.service
Line 6: enable vdsm-network.service
Line 7: enable mom-vdsm.service
Line 8: 
why do you disable ksmtuned?
Line 9: disable ksmtuned.service


https://gerrit.ovirt.org/#/c/43032/1/vdsm.spec.in
File vdsm.spec.in:

Line 739: # VDSM installs vdsm-modules-load.d.conf file - the following command 
will
Line 740: # refresh vdsm kernel modules requirements to start on boot
Line 741: /bin/systemctl restart systemd-modules-load.service >/dev/null 2>&1 
|| :
Line 742: 
Line 743: # This call will trigger vdsmd.preset file and enable vdsm required 
services
you can remove 'this call will'...
Line 744: %systemd_post vdsmd.service
Line 745: 
Line 746: # VDSM installs unit files - daemon-reload will refresh systemd
Line 747: /bin/systemctl daemon-reload >/dev/null 2>&1 || :


-- 
To view, visit https://gerrit.ovirt.org/43032
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0affa3003e63bcb72d95b917d86dab3c0b58c637
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to