Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages ......................................................................
Patch Set 3: It is not about blocking the server but closing it properly. I checked coredump of a build with was stuck and noticed that we wait for server thread to join. This patch is an attempt to solve this issue. What you suggest is to stop reusing xmlrpc code. As you can see from the code the "levels of inheritance" were created because we need to change it the way connections are accepted and pass opened socket for processing. We spend good about of time to understand how to provide protocol detection without introducing too many changes to xmlrpc server. At this stage I would like to focus on solving issue with the builds being stuck on join. -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
