Martin Polednik has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/42736/4//COMMIT_MSG Commit Message: Line 7: virt: add logic for POWER cpu xml element Line 8: Line 9: Current flow in appendCpu caused ppc to be skipped, generating empty Line 10: element (<cpu/>). In order to specify cpu model on ppc, we have to use Line 11: libvirt's host-model element and power8 model. > can you point to the libvirt-side discussion about this compulsory use of h This was discussed in person, but will try. Migration: I don't understand. According to D. Gibson, it is possible to run the guest workarounds on both POWER8 and POWER8e guests and therefore, the migration will be safe in this case. Line 12: Line 13: This is currently the only way of safely adding CPU to ppc64le host. Line 14: Line 15: Change-Id: I9303b76904ef1344508136343104b37c09d2a370 -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
