Francesco Romani has posted comments on this change. Change subject: resourceManager: Avoid uneeded recursive locking ......................................................................
Patch Set 3: Code-Review+1 (2 comments) seems self-contained (since I'm not storage expert) and looks good to me https://gerrit.ovirt.org/#/c/43424/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-10 21:02:24 +0300 Line 4: Commit: Nir Soffer <[email protected]> Line 5: CommitDate: 2015-07-11 01:44:47 +0300 Line 6: Line 7: resourceManager: Avoid uneeded recursive locking typo: unneeded Line 8: Line 9: In registerNamesapce, when force registering an existing namespace, we Line 10: first try to remove the existing one using unregisterNamespace. Since Line 11: both public methods acquire an exclusive lock, we must use a recursive Line 5: CommitDate: 2015-07-11 01:44:47 +0300 Line 6: Line 7: resourceManager: Avoid uneeded recursive locking Line 8: Line 9: In registerNamesapce, when force registering an existing namespace, we typo: registerNamespace Line 10: first try to remove the existing one using unregisterNamespace. Since Line 11: both public methods acquire an exclusive lock, we must use a recursive Line 12: lock to avoid deadlock. Line 13: -- To view, visit https://gerrit.ovirt.org/43424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6658645bba178fa5f3821a56e3453f62d0c9db4f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
