Allon Mureinik has posted comments on this change.

Change subject: resize-lun: Rescan fiber channel devices
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

+1 on the code, minor comments on the commit message.

Also, please provide some details on how you verified this patch.

https://gerrit.ovirt.org/#/c/43388/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: resize-lun: Rescan fiber channel devices
Line 8: 
Line 9: The fc-scan utility currently scans in order to find new LUNs.
Line 10: In order to detect an increase in fiber channel LUNs, rescan of 
existing
"increase in fiber channel LUNs' size"
Line 11: devices is needed.
Line 12: 
Line 13: Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b
Line 14: Bug-Url:https://bugzilla.redhat.com/609689


Line 10: In order to detect an increase in fiber channel LUNs, rescan of 
existing
Line 11: devices is needed.
Line 12: 
Line 13: Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b
Line 14: Bug-Url:https://bugzilla.redhat.com/609689
Missing space after ":"


-- 
To view, visit https://gerrit.ovirt.org/43388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to