Francesco Romani has uploaded a new change for review. Change subject: vm: events: skip event after failed migration ......................................................................
vm: events: skip event after failed migration Engine doesn't want to receive 'Down' vm_status from the migration Destination side after a failed migration, and it is actually confused by this. So, add another exception on our flow and skip notification. Change-Id: I59ee80e6e59093be37bc022a77325b6775770ec9 Signed-off-by: Francesco Romani <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/43750/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 75458ac..59dc234 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1299,15 +1299,19 @@ except Exception: pass self.saveState() - if event_data and self._can_send_down_event(): + if event_data and self._can_send_down_event(exitReasonCode): self.send_status_event(**event_data) - def _can_send_down_event(self): + def _can_send_down_event(self, exit_reason): # Engine is confused if it receives Down event: # - after a synchronous destroy call. if self._destroyed: return False + # - after a failed migration, on Destination side + if exit_reason == vmexitreason.MIGRATION_FAILED: + return False + return True def status(self, fullStatus=True): -- To view, visit https://gerrit.ovirt.org/43750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59ee80e6e59093be37bc022a77325b6775770ec9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
