Nir Soffer has posted comments on this change. Change subject: tests: Add Mount equality and hash tests ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43975/4/tests/mountTests.py File tests/mountTests.py: Line 115: ]) Line 116: def test_not_equal_different_hash(self, spec1, spec2, file1, file2): Line 117: m1 = mount.Mount(spec1, file1) Line 118: m2 = mount.Mount(spec2, file2) Line 119: self.assertNotEqual(hash(m1), hash(m2)) > Why do we need this tests ? I thought the contract should be: See my reply in https://gerrit.ovirt.org/#/c/43988/2/tests/storageServerTests.py Line 120: Line 121: Line 122: class MountTests(TestCaseBase): Line 123: def testLoopMount(self): -- To view, visit https://gerrit.ovirt.org/43975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie958119aebfd2a5f96df14e9bba68a0c4f16f094 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
