Roman Mohr has posted comments on this change. Change subject: tests: Use more random interface names ......................................................................
Patch Set 3: Using choice instead of sample seems to be OK, but be aware that messages like this: SKIP: device vdsmtest-wrfM1 already exists; can't create bridge with the same name had nothing to do with the random name generator. The reason is that the same bridge is reused in every test in a test class. So if the deletion after one test fails, the setup for the next test sees that the bridge is still there and skips. The best solution I found so far is https://gerrit.ovirt.org/#/c/44028/ -- To view, visit https://gerrit.ovirt.org/44111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffcabc7992e787d1e2cf38ce4ad2164cc80c646e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
