Dan Kenigsberg has posted comments on this change. Change subject: Adding hooks support for NIC hotplug ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) oh, updating the unit test would be appreciated, too. .................................................... File vdsm_hooks/Makefile.am Line 73: before_vm_destroy \ Line 74: after_vm_destroy \ Line 75: before_vm_set_ticket \ Line 76: after_vm_set_ticket \ Line 77: before_nic_plug \ you're not the first, but please use tabs here, like most of the hooks. Line 78: after_nic_unplug \ Line 79: before_vdsm_start \ Line 80: after_vdsm_stop Line 81: -- To view, visit http://gerrit.ovirt.org/7224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I253104ee9831a881e2fb06f0a658631662611d77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Itzik Brown <itz...@mellanox.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
