Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/lvm.py Line 859: Line 860: Line 861: def removeVG(vgName): Line 862: pvs = tuple(pv for pv in _lvminfo._pvs.iterkeys() Line 863: if not isinstance(pv, Stub) and pv.vg_name == vgName) This should be done *after* call to vgremove Line 864: # PVS needs to be reloaded anyhow: if vg is removed they are staled, Line 865: # if vg remove failed, something must be wrong with devices and we want Line 866: # cache updated as well Line 867: _lvminfo._invalidatepvs(pvs) Line 863: if not isinstance(pv, Stub) and pv.vg_name == vgName) Line 864: # PVS needs to be reloaded anyhow: if vg is removed they are staled, Line 865: # if vg remove failed, something must be wrong with devices and we want Line 866: # cache updated as well Line 867: _lvminfo._invalidatepvs(pvs) invalidating before removing VG is raceful (can be refreshed before removal of vg) Line 868: # Remove the vg from the cache Line 869: _lvminfo._vgs.pop(vgName, None) Line 870: # and now destroy it Line 871: cmd = ["vgremove", "-f", vgName] -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
