Igor Lvovsky has posted comments on this change.
Change subject: BZ#811807 Enable network filtering
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 960: m = doc.createElement('source')
Line 961: m.setAttribute('bridge', self.network)
Line 962: iface.appendChild(m)
Line 963: if hasattr(self, 'filters'):
Line 964: filters = getattr(self, 'filters')
you don't need it.
If hasattr return True, you can use simple
self.filters
Line 965: for filterName in filters:
Line 966: m = doc.createElement('filterref')
Line 967: m.setAttribute('filter', filterName)
Line 968: iface.appendChild(m)
--
To view, visit http://gerrit.ovirt.org/7353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b3dc7021997f4d0c1194049b1c12ac3528f067
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
