Adam Litke has posted comments on this change. Change subject: Live Merge: Fix pre-extension calculation for chunked drives ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/44331/1//COMMIT_MSG Commit Message: Line 13: qcow2 volume as a result of the writes. The amount of growth can be Line 14: anywhere between 0 (if all writes are replacing old data) and the Line 15: allocated size of the top volume (if all writes target unallocated Line 16: blocks in the base volume). If the top volume is the active layer the Line 17: gamount of rowth required could be more due to writes from the VM that > gamount of rowth -> amount of growth Done Line 18: come after this calculation is performed. Line 19: Line 20: To prevent live merge failures when the base volume's LV is too small we Line 21: request an extension to accomodate the worst case scenario and increase Line 20: To prevent live merge failures when the base volume's LV is too small we Line 21: request an extension to accomodate the worst case scenario and increase Line 22: the base volume's LV by the size of the top volume's LV plus one Line 23: additional chunk. The LV will never be increased beyond the actual Line 24: capacity of the VM disk. > For active layer merge, we can extend the base volume when we extend the ac This sounds like a different patch to me. Line 25: Line 26: The old code extended the base volume's LV to the size of the top Line 27: volume's LV which does not cover all the possible scenarios. Line 28: https://gerrit.ovirt.org/#/c/44331/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4726: # the allocated size of 'top' plus one additional chunk to accomodate Line 4727: # additional writes to 'top' during the live merge operation. Line 4728: if drive.chunked: Line 4729: capacity, alloc, physical = self._getExtendInfo(drive) Line 4730: targetSize = baseSize + topSize > Lets rename this to maxAlloc, which explain this calculation better. Done Line 4731: self.extendDriveVolume(drive, baseVolUUID, targetSize, capacity) Line 4732: Line 4733: # Trigger the collection of stats before returning so that callers Line 4734: # of getVmStats after this returns will see the new job -- To view, visit https://gerrit.ovirt.org/44331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I959608dc2f5a71afca605610267478e8a16e2c4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
