Dan Kenigsberg has posted comments on this change. Change subject: register: Add --vdsm-uuid option ......................................................................
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44431/3/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 451: ) Line 452: Line 453: parser.add_argument( Line 454: '--vdsm-uuid', Line 455: help="Enforce VDSM UUID.", "Enforce" is very vague. How about using (here and elsewhere) something along lthe lines of "provide host uuid to be used instead vdsm.utils' default. useful for hosts with blank or buggy dmi" Line 456: ) Line 457: Line 458: # Using [1:] to remove the 'register' option from arguments Line 459: # and avoid vdsm-tool recognize it as an unknown option -- To view, visit https://gerrit.ovirt.org/44431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5926b635201662db53956dbac18b9a2981d6e645 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
