Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File Makefile.am Line 137: fi Line 138: Line 139: gen-VERSION: Line 140: if test -d .git; then \ Line 141: $(top_srcdir)/build-aux/pkg-version --full \ yeah, that's indeed better. Line 142: > $(distdir)/ve-t; \ Line 143: rm -f $(distdir)/VERSION; \ Line 144: mv $(distdir)/ve-t $(distdir)/VERSION; \ -- To view, visit http://gerrit.ovirt.org/7295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
