Francesco Romani has posted comments on this change. Change subject: supervdsm: move udevadm methods to udevadm module ......................................................................
Patch Set 2: (1 comment) looks nicer, and patch looks like code move + renaming. Will doublecheck move later. https://gerrit.ovirt.org/#/c/44808/2/lib/vdsm/udevadm.py File lib/vdsm/udevadm.py: Line 81: 'out %s\nerr %s' % (out, err)) Line 82: Line 83: Line 84: def _reload(): Line 85: if _has_reload(): to me looks simpler and nicer if we just inline this method. Drop this comment if _has_reload has 2+ callers, but it seems it is used just here. Line 86: reload = "--reload" Line 87: else: Line 88: reload = "--reload-rules" Line 89: cmd = [EXT_UDEVADM, 'control', reload] -- To view, visit https://gerrit.ovirt.org/44808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b72b580e77872068ae6357410d940a83626b05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
