Fabian Deutsch has posted comments on this change. Change subject: oop: close ioprocesses on vdsmd stop ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/45038/1/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 75: if (eol < now and name != clientName): Line 76: del _procPool[name] Line 77: Line 78: def closeAllIOProcesses(): Line 79: for name, (eol, proc) in _procPool.items(): Normally I'd check if _procPool is initialized, but it looks like this is not done in general, so fine for me. Line 80: proc.close() Line 81: Line 82: def _getRfhPool(clientName): Line 83: with _procPoolLock: -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
