Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: improve message when trying to attach import domain with 
wrong permissions (#842146)
......................................................................


Patch Set 5: (1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2012-08-22 11:14:41 +0300
Line 4: Commit:     Oved Ourfali <oourf...@redhat.com>
Line 5: CommitDate: 2012-08-23 10:31:23 +0300
Line 6: 
Line 7: vdsm: improve message when trying to attach import domain with wrong 
permissions (#842146)
Please drop the "vdsm:" prefix. We know this is a Vdsm patch.

Please adhere to project standard about mentioning the BZ#. I think they are 
currently

 Bug-Id: BZ#XXXXXX
Line 8: 
Line 9: https://bugzilla.redhat.com/842146
Line 10: 
Line 11: When a storage domain is attached, and there is something wrong with 
the


--
To view, visit http://gerrit.ovirt.org/7339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to