Ondřej Svoboda has posted comments on this change. Change subject: networkTests: normalize dict keys and values to str (from unicode) ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Please excuse the commit message, I'll fix it to include KernelConfig at least. Since this only improves readability of unittest's diff between KernelConfig and RunningConfig dicts, I did not want to include it in the main function (normalize). But I would prefer to do so if it is harmless. Otherwise I would convert the function to a @staticmethod. https://gerrit.ovirt.org/#/c/45201/2/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 431: _normalize_unicode Ido, is it safe to include this in normalize()? -- To view, visit https://gerrit.ovirt.org/45201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6362e04189f134ad27ee4e3c1991020b2eee91aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
