Deepak C Shetty has posted comments on this change. Change subject: add simple VM creation functional test ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File tests/functional/vmTests.py Line 44: kernelPath = "/boot/vmlinuz-" + kernelVer Line 45: initramfsPath = "/boot/initramfs-%s.img" % kernelVer Line 46: vmid = str(uuid.uuid4()) Line 47: conf = {'display': 'vnc', Line 48: 'initrd': initramfsPath, Can we say display:local so that we keep the baggage minimum, since we can't remove it. Line 49: 'kernel': kernelPath, Line 50: # Fedora uses dracut to create initramfs. The following Line 51: # arguments will be interpreted by init scripts created by Line 52: # dracut. Line 66: while True: Line 67: vmUp = self.isVMUp(vmid) Line 68: guestUp = self.isGuestUp(vmid) Line 69: if vmUp and guestUp: Line 70: break Wouldn't it be better to check for isGuestUp only when Vm is up, else don't do it.? Line 71: now = time.time() Line 72: if now - start > timeout: Line 73: raise Exception("Creating VM timeout.\n" Line 74: "VM Up: %r, Guest Up: %r.\n" -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches