Nir Soffer has posted comments on this change.

Change subject: hostdev: add udev rules for USB devices
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/44679/8/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 398: 
Line 399:         self.udevTriggerUSB(bus, device)
Line 400: 
Line 401:     @logDecorator
Line 402:     def releaseAppropriateUSBDevice(self, bus, device):
See my comments about this in older version of this patch.
Line 403:         rule_file = _UDEV_RULE_FILE_NAME_USB % (bus, device)
Line 404: 
Line 405:         rule = ('SUBSYSTEM=="usb", ATTRS{{busnum}}=="{}", '
Line 406:                 'ATTRS{{devnum}}=="{}", '


-- 
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f72f63186187254cd4aded0a2e6c396001ca28b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to