Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsm: move udevadm methods to udevadm module ......................................................................
supervdsm: move udevadm methods to udevadm module udevadm module already exists, so there is no reason to keep the method logic in supervdsm. udevadm also provides us with a means to execute a command, it is therefore used instead of EXT_UDEVADM. To keep the behavior same, Error raised by trigger is caught in supervdsm and re-raised as IOError (same as before the patch). Change-Id: Ie2b72b580e77872068ae6357410d940a83626b05 Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44808 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M configure.ac M lib/vdsm/constants.py.in M lib/vdsm/udevadm.py M vdsm/supervdsmServer 4 files changed, 45 insertions(+), 53 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/44808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2b72b580e77872068ae6357410d940a83626b05 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
