Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make removeNic cope with a missing ifcfg file ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/45932/2/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 648: try: Line 649: with open(cf) as nicFile: Line 650: hwlines = [line for line in nicFile if line.startswith( Line 651: 'HWADDR=')] Line 652: except IOError as e: > please check for errno.ENOENT correct. we should explode violently if we see EPERM (or anything but ENOENT). Please fix in master, first. Line 653: logging.warning("%s couldn't be read (errno %s)", cf, e.errno) Line 654: try: Line 655: hwlines = ['HWADDR=%s\n' % netinfo.gethwaddr(nic)] Line 656: except IOError as e: -- To view, visit https://gerrit.ovirt.org/45932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica18b30d508224903e7dcb898d74ae8ec35d4a23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
