Nir Soffer has posted comments on this change. Change subject: qemuimg: add support for convert progress ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 269: if not self._stream.closed: Line 270: return Line 271: Line 272: with self._term_lock: Line 273: self._command.wait() > If the stream is closed the command should exit very quickly. We should not assume this. Do you have any idea why we need the lock? Line 274: Line 275: if self._command.returncode != 0: Line 276: raise QImgError(self._command.returncode, "", self.stderr) Line 277: -- To view, visit https://gerrit.ovirt.org/33910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
