Francesco Romani has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/45738/14/tests/tasksetTests.py File tests/tasksetTests.py: Line 62: self.proc = multiprocessing.Process(target=_run_helper) Line 63: self.proc.start() Line 64: self.assertTrue(self.running.wait(0.5)) Line 65: Line 66: cpu_list = ['1'] > This wil fail if running on vm with single cpu, better pin to cpu 0 (same i Done (thanks for pointing this out -again!) Line 67: taskset.set(self.proc.pid, cpu_list) Line 68: self.assertEqual(taskset.get(self.proc.pid), cpu_list) Line 69: Line 70: def test_set_from_child(self): https://gerrit.ovirt.org/#/c/45738/14/vdsm.spec.in File vdsm.spec.in: Line 87 Line 88 Line 89 Line 90 Line 91 > Lets depend on cpopen >= 1.4 Done -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
