Yaniv Bronhaim has posted comments on this change. Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py: Line 29: from . import m2cutils as sslutils Line 30: from .m2cutils import SSLSocket Line 31: from .m2cutils import SSLHandshakeDispatcher Line 32: _USED_M2C = True Line 33: except ImportError: > There can be difference in how we built vdsm and how we configured. That's exactly the reason why I don't like this direction. its messed up - how the user should know if he installed rpm with m2c or not.. :/ Line 34: _log.warning('Configured m2crypto but not available falling back' Line 35: ' to ssl') Line 36: else: Line 37: # we need it to satisfy pyflakes -- To view, visit https://gerrit.ovirt.org/44689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
