Ondřej Svoboda has posted comments on this change. Change subject: net: tests: additional tests for host QOS ......................................................................
Patch Set 7: Code-Review-1 (11 comments) Great job! As you said, I was only able to look at the surface of the code. https://gerrit.ovirt.org/#/c/44699/7/tests/nettestlib.py File tests/nettestlib.py: Line 98: IPRoute2Error I assume nothing should go wrong but during development of other tests it might happen that it is not possible to remove the bridge (or, further down, a VLAN). Line 109: addDevice Do I get it right that you want to differentiateMethodNames from standalone_function_names? I hoped we would gradually converge to just snake_case. (I know I am a little late to complain, but not late to understand.) Line 120: vlan_tag=None Why not tag=16? If I were to use vlan_device() I would want to know what the actual/effective default tag is. The name 'tag' is unambiguous in the context of the function call. Line 121: if vlan_tag is None: : vlan = Vlan(link) : else: : vlan = Vlan(link, vlan_tag) Then this would be just vlan = Vlan(link, tag) https://gerrit.ovirt.org/#/c/44699/7/tests/tcTests.py File tests/tcTests.py: Line 390: analise analyse Line 403: net_ent "Network entity" is a nice term but I remember "net_ent" used to confuse me a lot. I prefer just "device" in networking context but I must admit that "iface" is generally better, unambiguous. Line 405: xrange xrange is be gone in Python 3, range will suffice here. (six.moves.xrange is too much effort here) Line 420: vlan vlans Line 421: 16 Explicit tag=16 fits here nicely. Line 494: cls "class" is better. I think of "cls" as a reserved word (albeit not enforced), much like "self". Line 520: _assertions_on_root_class Could you order functions in a way that basic assertions were set apart from important checks? I tend to put more complex functions first so analyses and their helper functions would go before assertions, but you can do it the other way as well. -- To view, visit https://gerrit.ovirt.org/44699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad639a9ad04593cfd477f60a8272614f3446522 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
