Igor Lvovsky has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) Thanks for the patch Royce. Just a minor comment .................................................... File vdsm.spec.in Line 65: Requires: python >= 2.7.3 Line 66: Requires: qemu-kvm >= 2:0.15.0-4 Line 67: Requires: qemu-img >= 2:0.15.0-4 Line 68: #readonly lease ignored by default on 0.9.11.4-3 Line 69: Requires: libvirt >= 0.9.13-1 I think 0.9.13-3 is better. * Fri Jul 20 2012 Daniel Veillard <[email protected]> - libvirt-0.9.13-3.el6 - fix the package split to be similar to 6.3 one instead of upstream * Tue Jul 03 2012 Daniel Veillard <[email protected]> - libvirt-0.9.13-2.el6 - fix a package dependency problem making -1 uninstallable Line 70: Requires: libvirt-python, libvirt-lock-sanlock Line 71: Requires: iscsi-initiator-utils >= 6.2.0.872-14 Line 72: Requires: device-mapper-multipath >= 0.4.9-18 Line 73: Requires: e2fsprogs >= 1.41.14 -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
