Ido Barkan has posted comments on this change. Change subject: hooks: ovs: move libvirt configuration into a separate module ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/46910/3/vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py File vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py: Line 35: for net, attrs in nets.iteritems(): > Can you merge the two loops? They seem complementary and independent of eac +1 Line 46: for net, net_xml in libvirt_create.items(): > for net_xml in six.itervalues(libvirt_create): six.iteritems I think -- To view, visit https://gerrit.ovirt.org/46910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I775edc776c738822ed955ffb0b7885dae450b667 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
