Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 689: if out and 'clock_sync' in out: I was not clear, I'm afraid. I was saying that checking for existence is not really needed. On error, out is set to None, and that's all that needs to be added. Line 690: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S') -- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches