Dan Kenigsberg has submitted this change and it was merged. Change subject: ImageManifest: introduce ImageManifest class ......................................................................
ImageManifest: introduce ImageManifest class In order to safely share storage code between the traditional SPM verbs and the new SDM verbs we must refactor the code from the Image class. We want to share the parts which deal with image "metadata" (ie. the repoPath and imageDir, volumeChain, etc). These elements will be moved into a new ImageManifest class while the SPM operations will remain in the Image class. As a first step, create the new class and add repoPath and getImageDir. Many of the other candidate functions rely on the VolumeMetadata refactoring and will be added later. Change-Id: Ic7a78aef10902b9baf6f88d2e053e2232e2a1267 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/43551 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> --- M tests/sdm_indirection_tests.py M vdsm/storage/image.py 2 files changed, 52 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7a78aef10902b9baf6f88d2e053e2232e2a1267 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
