Francesco Romani has submitted this change and it was merged.
Change subject: lvm: Check if device in VG before extend
......................................................................
lvm: Check if device in VG before extend
Before extending a VG, VDSM needs to check that none of
the additional devices are not already part of the VG.
Without this protection, LVM will create a new PV with the
same device. After extending VG, its metadata will updated
with new PV. As a result, the VG will be partial.
pvs output after creating new PV with same device:
# pvs
WARNING: Device for PV 2fDjgH-TeKA-1Vy2-NMMv-GB9n-op0w-g2Nyrd not
found or rejected by a filter.
PV
/dev/mapper/360014054bf6dd7d14fd40c9ac3b5dbe8
unknown device
Change-Id: Ifec2503094d6a0ecdd32e5e62f9c01a1469145f3
Bug-Url: https://bugzilla.redhat.com/1265907
Signed-off-by: Fred Rolland <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/45946
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik <[email protected]>
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/46651
Reviewed-by: Francesco Romani <[email protected]>
Continuous-Integration: Francesco Romani <[email protected]>
---
M vdsm/storage/lvm.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved; Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/46651
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifec2503094d6a0ecdd32e5e62f9c01a1469145f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
