Nir Soffer has posted comments on this change. Change subject: hsm: Remove support for size in sectors as int ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47381/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 8291: ## Line 8292: {'command': {'class': 'Volume', 'name': 'create'}, Line 8293: 'data': {'volumeID': 'UUID', 'storagepoolID': 'UUID', Line 8294: 'storagedomainID': 'UUID', 'imageID': 'UUID', Line 8295: 'size': 'uint', 'volFormat': 'VolumeFormat', > It if's supposed to be a string, then make it a string here. Are you sure? we have many other places that use uint but requires a string argument. Line 8296: 'preallocate': 'VolumeAllocation', 'diskType': 'DiskType', Line 8297: 'desc': 'str', 'srcImgUUID': 'UUID', 'srcVolUUID': 'UUID'}, Line 8298: 'returns': 'UUID'} Line 8299: -- To view, visit https://gerrit.ovirt.org/47381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
