Dan Kenigsberg has posted comments on this change.

Change subject: vdsmd always restarts libvirtd upon start-up
......................................................................


Patch Set 17: Looks good to me, approved

Yaniv, I wanted to verify your patch, but I cannot reproduce the bug even 
without it. I am using EL6 with libvirt-0.9.10-21.el6.x86_64 and u/s & d/s vdsm.

Restarting vdsm does not restart libvirt, it only *says* that it does:

[dkenigsb@zeus01 vdsm.git]$ ps -ww `pgrep libvirt`
  PID TTY      STAT   TIME COMMAND
19870 ?        Ssl    0:00 /usr/sbin/libvirtd --listen
[dkenigsb@zeus01 vdsm.git]$ sudo service vdsmd restart
Shutting down vdsm daemon: 
vdsm watchdog stop                                         [  OK  ]
vdsm stop                                                  [  OK  ]
Stopping libvirtd daemon: libvirtd: libvirtd is managed by upstart and started, 
use initctl instead
vdsm: libvirt already configured for vdsm                  [  OK  ]
Starting iscsid: 
Starting up vdsm daemon: 
vdsm start                                                 [  OK  ]
[dkenigsb@zeus01 vdsm.git]$ ps -ww `pgrep libvirt`
  PID TTY      STAT   TIME COMMAND
19870 ?        Ssl    0:00 /usr/sbin/libvirtd --listen

please note that this bug is about TEXT only!!

--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to