Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: retry when flushing socket ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/47637/2/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 299: # An final socket error may have occurred here, Line 300: # such as the local error ECONNABORTED. Line 301: break Line 302: except SSL.SSLError as e: Line 303: if e.message == 'bad write retry': > we don't have any other mean to do this check? an error code, maybe? As you see m2crypto is very good at giving us error code. (everything is in message). Line 304: continue Line 305: else: Line 306: break Line 307: -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
