Milan Zamazal has posted comments on this change. Change subject: virt: periodic: reduce NotConnectedError noise ......................................................................
Patch Set 14: Code-Review-1 (2 comments) Looks fine to me, I'd just suggest to polish typos in the commit message (they may be more than those I marked). https://gerrit.ovirt.org/#/c/44813/14//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-10-13 16:15:34 +0200 Line 6: Line 7: virt: periodic: reduce NotConnectedError noise Line 8: Line 9: periodic operations have well known races on Periodic ... Line 10: VM startup and VM shutdown. Line 11: These races are well known, because periodic are Line 12: asynchronous with respect VM startup/shutdown, Line 13: and are benign because operations are just supposed Line 8: Line 9: periodic operations have well known races on Line 10: VM startup and VM shutdown. Line 11: These races are well known, because periodic are Line 12: asynchronous with respect VM startup/shutdown, ... respect to VM ... Line 13: and are benign because operations are just supposed Line 14: to be retried next cycle. Line 15: Line 16: Under high load and/or unresponsive libvirt, we may -- To view, visit https://gerrit.ovirt.org/44813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I920e3b0b0e80e0a66ad199607068424986933d3a Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
