Dan Kenigsberg has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc ......................................................................
Patch Set 11: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/45789/11//COMMIT_MSG Commit Message: Line 9: default "default" is misleading. we completely abandon xmlrpc on the tests. https://gerrit.ovirt.org/#/c/45789/11/tests/functional/utils.py File tests/functional/utils.py: Line 70: def __init__(self): Line 71: retry(self.start, (socket.error, KeyError), tries=30) Line 72: Line 73: def start(self): Line 74: requestQueues = config.get('addresses', 'request_queues') since at the moment we have a supposed performance regression when using jsonrpc, would you please keep the xmlrpc abilities. If configured to use xmlrpc, use the old code. and use jsonrpc here only if asked (in a config file, or ENV variable) Line 75: requestQueue = requestQueues.split(",")[0] Line 76: self.vdscli = jsonrpcvdscli.connect(requestQueue, xml_compat=False) Line 77: self.netinfo = self._get_netinfo() Line 78: if config.get('vars', 'net_persistence') == 'unified': Line 165: # add calling method for logs Line 166: test_method, code_line = stack[3][3], stack[3][2] Line 167: options['_caller'] = '{}:{}'.format(test_method, code_line) Line 168: result = self.vdscli.setupNetworks(networks, bonds, Line 169: options, timeout=30) this seems too much like a "real" argument to setupNetwork. how about renaming it to _timeout? or _transport_timeout? Line 170: return _parse_result(result) Line 171: Line 172: def _vlanInRunningConfig(self, devName, vlanId): Line 173: for net, attrs in self.config.networks.iteritems(): Line 206: done = True Line 207: Line 208: def getVdsStats(self): Line 209: result = self.vdscli.getVdsStats() Line 210: return _parse_result(result, True) here you could check in runtime whether to return the 'result' or the 'info'. Line 211: Line 212: def getAllVmStats(self): Line 213: result = self.vdscli.getAllVmStats() Line 214: return _parse_result(result, True) -- To view, visit https://gerrit.ovirt.org/45789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaba1e2811f010e4509a658acef8040ad8f39cece Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
