Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/47964/1//COMMIT_MSG Commit Message: Line 10: they raise when one command run through utils.execCmd fails. Line 11: Line 12: Since this Error is closely related to utils.execCmd, we Line 13: remove the duplicate definition of Error and we move it Line 14: in one place, alogside execCmd itself. ... alongside ... Line 15: Line 16: Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/udevadm.py File lib/vdsm/udevadm.py: Line 23 Line 24 Line 25 Line 26 Line 27 > Could be good solution for a future patch, when we have a clear need. For t Referring the same class via different paths raises some red flags in my head. I also can't say it's an ultimately bad thing to do, but I can e.g. imagine someone, once having the clear need without realizing the aliases, debugging his code for a while and then hitting his head against a wall. Not a big issue for me, just thinking aloud about what "simplest" actually means here. -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia490c055e6e5c637eba82ccffb9d2dfc748db8f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
